Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring childcare to the top #587

Merged
merged 3 commits into from
Jun 29, 2024
Merged

Bring childcare to the top #587

merged 3 commits into from
Jun 29, 2024

Conversation

bvdmitri
Copy link
Collaborator

@bvdmitri bvdmitri commented Jun 27, 2024

Briefly Describe your changes

This PR brings the childcare info to the top of the website. This was an explicit request from Long. We got about 5 children per day where the maximum is 15.

Checklist for merge

  • I built the website locally and tested it using Franklin.serve()
  • All CI checks have passed and you have tested the online version (click on the list of checks and click Build and Deploy / Preview to see the preview)
  • Somebody else reviewed my changes (use your best judgement if you need to merge quickly

After merge

  • Closed relevant issues

@bvdmitri bvdmitri requested a review from pabloferz June 27, 2024 17:29
@pabloferz
Copy link
Contributor

I feel that the box makes it look out of place. Maybe we could have it as a regular section (we have the box at the end any way).

@bvdmitri
Copy link
Collaborator Author

Fair point, what about something like this ?
image

@giordano
Copy link
Contributor

Maybe I should open a separate ticket about this, but it's weird that hovering over the image looks like they're links pointing to a separate page, but clicking on them does nothing:
image
Note the mouse pointer which turns into the click-link shape

@bvdmitri
Copy link
Collaborator Author

Yeah, we can remove those in a separate PR, probably some unnecessary CSS styling

@pabloferz
Copy link
Contributor

Fair point, what about something like this ? image

Yes. That's much better!

@vchuravy
Copy link
Contributor

I was about the mention on #589 that the whole section is now pushed below "previous conference" making it unlikely that folks will actually see it.

2024/index.md Outdated
<div class="row masonry" data-masonry='{ "itemSelector": ".grid-item", "percentPosition": true }'>
~~~

\begin{widebox}{title="Diversity Initiative & Childcare", color="purple"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also mention the mentorship program added in #589

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we merge and publish ASAP? Only one week to go and I still don’t see it on the front page. Many thanks

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lochen906 merged now

@bvdmitri bvdmitri merged commit 71a8e88 into franklin Jun 29, 2024
2 checks passed
@pabloferz pabloferz deleted the top-childcare branch June 30, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants