Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove REPL dependency #3459

Merged
merged 1 commit into from
Sep 7, 2024
Merged

Remove REPL dependency #3459

merged 1 commit into from
Sep 7, 2024

Conversation

topolarity
Copy link
Contributor

For non-interactive (e.g. script or executable-like) workflows, REPL is a pretty heavy dependency that touches a lot of global state.

Avoid the dependency by copying the levenshtein implementation instead.

bkamins
bkamins reviewed Aug 29, 2024
View reviewed changes
src/other/index.jl Outdated Show resolved Hide resolved
bkamins
bkamins reviewed Aug 29, 2024
View reviewed changes
src/other/index.jl Outdated Show resolved Hide resolved
bkamins
bkamins reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@bkamins bkamins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left some minor comments

@bkamins bkamins added the ecosystem Issues in DataFrames.jl ecosystem label Aug 29, 2024
@bkamins bkamins added this to the 1.7 milestone Aug 29, 2024
@bkamins bkamins merged commit bb63361 into JuliaData:main Sep 7, 2024
6 of 8 checks passed
@bkamins
Copy link
Member

bkamins commented Sep 7, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkamins bkamins bkamins approved these changes

Assignees
No one assigned
Labels
ecosystem Issues in DataFrames.jl ecosystem
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
2 participants
@topolarity @bkamins