-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No agnostic line search #98
Conversation
@matbesancon this still errors |
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
- Coverage 89.78% 89.52% -0.26%
==========================================
Files 24 23 -1
Lines 695 678 -17
==========================================
- Hits 624 607 -17
Misses 71 71 ☔ View full report in Codecov by Sentry. |
Ah my bad I hadn't released the better error printing in case of NaNs. But this will improve the error message only, the underlying problem here seems to be with NaN elements in the gradient no? |
It's interesting that it works on 1.7 though |
maybe you are not reaching the point where the gradient evaluates to NaN? The RNG in Julia changed from 1.7 onwards if I recall |
Possibly. Not sure how to debug this though, the MWE is pretty involved |
one ugly way would be to print the gradient at every iteration, or print the direction in the LMO itself |
let's debug that between main dish and dessert next week |
Fixed in #116. |
Testing the waters to see if #40 has been solved by the latest release of FrankWolfe mentioned in ZIB-IOL/FrankWolfe.jl#387