Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No agnostic line search #98

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

No agnostic line search #98

wants to merge 2 commits into from

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Sep 20, 2023

Testing the waters to see if #40 has been solved by the latest release of FrankWolfe mentioned in ZIB-IOL/FrankWolfe.jl#387

@gdalle
Copy link
Member Author

gdalle commented Sep 20, 2023

@matbesancon this still errors

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.26% ⚠️

Comparison is base (0493719) 89.78% compared to head (fc9992e) 89.52%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
- Coverage   89.78%   89.52%   -0.26%     
==========================================
  Files          24       23       -1     
  Lines         695      678      -17     
==========================================
- Hits          624      607      -17     
  Misses         71       71              

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matbesancon
Copy link

Ah my bad I hadn't released the better error printing in case of NaNs. But this will improve the error message only, the underlying problem here seems to be with NaN elements in the gradient no?

@gdalle
Copy link
Member Author

gdalle commented Sep 20, 2023

It's interesting that it works on 1.7 though

@matbesancon
Copy link

maybe you are not reaching the point where the gradient evaluates to NaN? The RNG in Julia changed from 1.7 onwards if I recall

@gdalle
Copy link
Member Author

gdalle commented Sep 23, 2023

Possibly. Not sure how to debug this though, the MWE is pretty involved

@matbesancon
Copy link

one ugly way would be to print the gradient at every iteration, or print the direction in the LMO itself

@matbesancon
Copy link

let's debug that between main dish and dessert next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants