Skip to content

Commit

Permalink
Small followup to #526 (#528)
Browse files Browse the repository at this point in the history
* Oops

* Update `versioninfo()` output

* Update contributing docs
  • Loading branch information
christiangnrd authored Jan 29, 2025
1 parent 4293d1a commit 1b811cb
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 13 deletions.
18 changes: 9 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,20 +67,20 @@ importing the package:
julia> using Metal
julia> Metal.versioninfo()
macOS 15.0.0, Darwin 24.0.0
macOS 15.3.0, Darwin 24.3.0
Toolchain:
- Julia: 1.11.0
- Julia: 1.11.3
- LLVM: 16.0.6
Julia packages:
- Metal.jl: 1.4.0
- GPUArrays: 10.3.1
- GPUCompiler: 0.27.8
- KernelAbstractions: 0.9.27
- ObjectiveC: 3.1.0
- LLVM: 9.1.2
- LLVMDowngrader_jll: 0.3.0+1
- Metal.jl: 1.5.1
- GPUArrays: 11.2.1
- GPUCompiler: 1.1.0
- KernelAbstractions: 0.9.33
- ObjectiveC: 3.3.0
- LLVM: 9.2.0
- LLVMDowngrader_jll: 0.6.0+0
1 device:
- Apple M2 Max (64.000 KiB allocated)
Expand Down
5 changes: 3 additions & 2 deletions docs/src/faq/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,10 @@ skip the first two steps.
2. Create high-level Julia structures and functionality
3. Create tests for added functionality

`struct`s and `enums` for Objective-C interfaces are automatically generated (see res/wrap/),
Objective-C object definitions, `struct`s, and `enums` for Objective-C interfaces are automatically generated (see res/wrap/),
so you should not have to define them. If using a struct for the first time in a higher-level
interface, remember to add tests! You may need to define more functions around the structs.
interface, remember to add tests! Objective-C object methods and constructors are not yet automtically
generatied, so any contributions there are welcome.

## Mapping to Metal Intrinsics

Expand Down
6 changes: 6 additions & 0 deletions lib/mtl/libmtl.jl
Original file line number Diff line number Diff line change
Expand Up @@ -2662,6 +2662,12 @@ end
@autoproperty label::id{NSString} setter = setLabel
end

@objcwrapper immutable = true MTLSharedEventListener <: NSObject

@objcproperties MTLSharedEventListener begin
@autoproperty dispatchQueue::id{dispatch_queue_t}
end

@objcwrapper immutable = false MTLSharedEvent <: MTLEvent

@objcproperties MTLSharedEvent begin
Expand Down
2 changes: 0 additions & 2 deletions res/wrap/libmtl.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ printer_blacklist = [
# Temporarily disable MTLFunctionLog because
# "function" property breaks formatter
"MTLFunctionLog",
# Don't print because dispatch_queue_t ??
"MTLSharedEventListener",
]

[codegen]
Expand Down

0 comments on commit 1b811cb

Please sign in to comment.