Bump compat constraint on Functors to 0.5 #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You would need to make sure that the new behaviour of |
|
I'll kindly note that KernelFunctions is indirectly limiting other packages (via the Functors dependency) from updating Flux. Our package will unfortunately have to drop KernelFunctions instead. I'm not familiar with the internals or testing of the KernelFunctions package, but the CI results on 1.6 and 1 for this PR looks to be the same as the previous PR. |
|
I will take a closer look. |
|
It looks like the tests are failing like on master, however inspecting the resolution it looks like 0.4.12 was used in the tests. @axsk could you also update the compat in |
This was referenced Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Proposed changes
What alternatives have you considered?
Breaking changes