Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial stab at Buildkite CI config #849

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

staticfloat
Copy link
Member

@staticfloat staticfloat commented Sep 18, 2023

@staticfloat staticfloat force-pushed the sf/buildkite branch 3 times, most recently from c54c8b4 to 2a8332f Compare September 18, 2023 17:34
@DilumAluthge
Copy link
Member

Ref #846

@staticfloat staticfloat force-pushed the sf/buildkite branch 3 times, most recently from 326aa2e to a041aad Compare September 18, 2023 18:17
@staticfloat
Copy link
Member Author

Next steps:

  1. Use a rootfs image on Linux to provide compilers
  2. Use a docker image on windows to provide compilers

@IanButterworth
Copy link
Member

Next steps as in in a followup PR?

Also:

  • Disable GHA CI

@sloede
Copy link
Collaborator

sloede commented Oct 4, 2023

Right now, the Buildkite result details are not visible for unprivileged users (such as myself).

@staticfloat
Copy link
Member Author

No, it has to be a part of this PR, as otherwise it's just constantly failing.

@fredrikekre fredrikekre self-assigned this Dec 13, 2023
@DilumAluthge
Copy link
Member

DilumAluthge commented Oct 15, 2024

It looks like work on this PR has paused for now.

Currently, the packagecompiler-dot-jl Buildkite pipeline (https://buildkite.com/julialang/packagecompiler-dot-jl) is posting a failing (❌) commit status on every PR. This is expected, but it does add some visual noise when looking through the list of PRs.

@staticfloat @fredrikekre I am going to disable the Buildkite commit statusfor now. Once work on this PR has resumed, we can re-enable the Buildkite commit status.

To re-enable the Buildkite commit status, do the following steps:

  1. Log in to Buildkite (log in to GitHub first, then go to https://buildkite.com/sso/julialang and click the green "Sign in to GitHub" button to SSO).
  2. Go to the packagecompiler-dot-jl pipeline: https://buildkite.com/julialang/packagecompiler-dot-jl
  3. Click on settings: https://buildkite.com/julialang/packagecompiler-dot-jl/settings
  4. In the left-hand side, click on GitHub: https://buildkite.com/julialang/packagecompiler-dot-jl/settings/repository
  5. Find the checkbox labeled "Update commit statuses", and check it.
  6. Click the green "Save GitHub Settings" button at the bottom of the page.

(I can also perform those steps, if someone pings me.)

@DilumAluthge DilumAluthge removed the request for review from KristofferC October 16, 2024 06:00
@DilumAluthge DilumAluthge changed the title Initial stab at buildkite CI config Initial stab at Buildkite CI config Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.56%. Comparing base (b2e852b) to head (f68db05).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #849   +/-   ##
=======================================
  Coverage   84.56%   84.56%           
=======================================
  Files           3        3           
  Lines         823      823           
=======================================
  Hits          696      696           
  Misses        127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants