Compiler/ssair/passes: _lift_svec_ref: improve type stability
#57633
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making the closure capture a `SimpleVector` instead of a type should improve type stability. Also deduplicated some common subexpressions while at it.
|
Decreases the invalidation count when running the following code from 512 to 490: struct I <: Integer end
Base.Int(::I) = 7Reproduce with: ./julia -E 'using SnoopCompileCore; i=(@snoop_invalidations (struct I <: Integer end; Base.Int(::I) = 7)); using SnoopCompile; length(uinvalidated(i))' |
|
bump |
|
In case it's useful, here are some (maybe all, didn't check the diff comprehensively) of the fixed invalidations: {
"method_instance": {
"method": "_mapreducedim!(f, op, R::AbstractArray, A::Union{Base.AbstractBroadcasted, AbstractArray}) @ Base reducedim.jl:253",
"method_instance": "MethodInstance for Base._mapreducedim!(::Function, ::Function, ::AbstractArray, ::UnitRange{Int64})"
},
"children": [
{
"method_instance": {
"method": "mapreducedim!(f, op, R::AbstractArray, A::Union{Base.AbstractBroadcasted, AbstractArray}) @ Base reducedim.jl:293",
"method_instance": "MethodInstance for Base.mapreducedim!(::Function, ::Function, ::AbstractArray, ::UnitRange{Int64})"
},
"children": [
{
"method_instance": {
"method": "_mapreduce_dim(f, op, ::Base._InitialValue, A::Union{Base.AbstractBroadcasted, AbstractArray}, dims) @ Base reducedim.jl:340",
"method_instance": "MethodInstance for Base._mapreduce_dim(::Function, ::Function, ::Base._InitialValue, ::UnitRange{Int64}, ::Function)"
},
"children": [
{
"method_instance": {
"method": "var\"#mapreduce#719\"(dims, init, ::typeof(mapreduce), f, op, A::Union{Base.AbstractBroadcasted, AbstractArray}) @ Base reducedim.jl:326",
"method_instance": "MethodInstance for Base.var\"#mapreduce#719\"(::Function, ::Base._InitialValue, ::typeof(mapreduce), ::Function, ::typeof(|), ::UnitRange{Int64})"
},
"children": [
{
"method_instance": {
"method": "kwcall(::NamedTuple, ::typeof(mapreduce), f, op, A::Union{Base.AbstractBroadcasted, AbstractArray}) @ Base reducedim.jl:326",
"method_instance": "MethodInstance for Core.kwcall(::NamedTuple{(:dims,), <:Tuple{Function}}, ::typeof(mapreduce), ::Function, ::typeof(|), ::UnitRange{Int64})"
},
"children": [
{
"method_instance": {
"method": "var\"#_any#773\"(kw::Base.Pairs{Symbol, V, NTuple{N, Symbol}, NamedTuple{names, T}} where {V, N, names, T<:NTuple{N, Any}}, ::typeof(Base._any), f, A, dims) @ Base reducedim.jl:1008",
"method_instance": "MethodInstance for Base.var\"#_any#773\"(::Base.Pairs{Symbol, Union{}, Tuple{}, @NamedTuple{}}, ::typeof(Base._any), ::Function, ::UnitRange{Int64}, ::Function)"
},
"children": [
{
"method_instance": {
"method": "_any(f, A, dims; kw...) @ Base reducedim.jl:1008",
"method_instance": "MethodInstance for Base._any(::Function, ::UnitRange{Int64}, ::Function)"
},
"children": [
{
"method_instance": {
"method": "var\"#any#747\"(dims, ::typeof(any), f::Function, a::AbstractArray) @ Base reducedim.jl:989",
"method_instance": "MethodInstance for Base.var\"#any#747\"(::Function, ::typeof(any), ::Function, ::UnitRange{Int64})"
},
"children": [
{
"method_instance": {
"method": "any(f::Function, a::AbstractArray; dims) @ Base reducedim.jl:989",
"method_instance": "MethodInstance for any(::Compiler.var\"#_lift_svec_ref##2#_lift_svec_ref##3\"{TypeVar, Type{_A}} where _A, ::UnitRange{Int64})"
},
"children": [
{
"method_instance": {
"method": "_lift_svec_ref(def::Expr, compact::Compiler.IncrementalCompact) @ Compiler ../usr/share/julia/Compiler/src/ssair/passes.jl:1016",
"method_instance": "MethodInstance for Compiler._lift_svec_ref(::Expr, ::Compiler.IncrementalCompact)"
},
"children": [
{
"method_instance": {
"method": "lift_svec_ref!(compact::Compiler.IncrementalCompact, idx::Int64, stmt::Expr) @ Compiler ../usr/share/julia/Compiler/src/ssair/passes.jl:875",
"method_instance": "MethodInstance for Compiler.lift_svec_ref!(::Compiler.IncrementalCompact, ::Int64, ::Expr)"
},
"children": [
{
"method_instance": {
"method": "sroa_pass!(ir::Compiler.IRCode, inlining::Union{Nothing, Compiler.InliningState}) @ Compiler ../usr/share/julia/Compiler/src/ssair/passes.jl:1212",
"method_instance": "MethodInstance for Compiler.sroa_pass!(::Compiler.IRCode, ::Compiler.InliningState)"
},
"children": [
{
"method_instance": {
"method": "run_passes_ipo_safe(ci::Core.CodeInfo, sv::Compiler.OptimizationState, optimize_until) @ Compiler ~/tmp/jl/julia-git/Compiler_ssair_lift_svec_ref_closure_type_stability/usr/share/julia/Compiler/src/optimize.jl:1036",
"method_instance": "MethodInstance for Compiler.run_passes_ipo_safe(::Core.CodeInfo, ::Compiler.OptimizationState, ::Nothing)"
},
"children": [
{
"method_instance": {
"method": "run_passes_ipo_safe(ci::Core.CodeInfo, sv::Compiler.OptimizationState) @ Compiler ~/tmp/jl/julia-git/Compiler_ssair_lift_svec_ref_closure_type_stability/usr/share/julia/Compiler/src/optimize.jl:1036",
"method_instance": "MethodInstance for Compiler.run_passes_ipo_safe(::Core.CodeInfo, ::Compiler.OptimizationState)"
},
"children": [
{
"method_instance": {
"method": "optimize(interp::Compiler.AbstractInterpreter, opt::Compiler.OptimizationState, caller::Compiler.InferenceResult) @ Compiler ~/tmp/jl/julia-git/Compiler_ssair_lift_svec_ref_closure_type_stability/usr/share/julia/Compiler/src/optimize.jl:1015",
"method_instance": "MethodInstance for Compiler.optimize(::Compiler.AbstractInterpreter, ::Compiler.OptimizationState, ::Compiler.InferenceResult)"
},
"children": [
{
"method_instance": {
"method": "finish_cycle(::Compiler.AbstractInterpreter, frames::Vector{Union{Compiler.IRInterpretationState, Compiler.InferenceState}}, cycleid::Int64) @ Compiler ~/tmp/jl/julia-git/Compiler_ssair_lift_svec_ref_closure_type_stability/usr/share/julia/Compiler/src/typeinfer.jl:222",
"method_instance": "MethodInstance for Compiler.finish_cycle(::Compiler.AbstractInterpreter, ::Vector{Union{Compiler.IRInterpretationState, Compiler.InferenceState}}, ::Int64)"
},
"children": [
]
},
{
"method_instance": {
"method": "finish_cycle(::Compiler.AbstractInterpreter, frames::Vector{Union{Compiler.IRInterpretationState, Compiler.InferenceState}}, cycleid::Int64) @ Compiler ~/tmp/jl/julia-git/Compiler_ssair_lift_svec_ref_closure_type_stability/usr/share/julia/Compiler/src/typeinfer.jl:222",
"method_instance": "MethodInstance for Compiler.finish_cycle(::Compiler.NativeInterpreter, ::Vector{Union{Compiler.IRInterpretationState, Compiler.InferenceState}}, ::Int64)"
},
"children": [
]
},
{
"method_instance": {
"method": "finish_nocycle(::Compiler.AbstractInterpreter, frame::Compiler.InferenceState) @ Compiler ~/tmp/jl/julia-git/Compiler_ssair_lift_svec_ref_closure_type_stability/usr/share/julia/Compiler/src/typeinfer.jl:200",
"method_instance": "MethodInstance for Compiler.finish_nocycle(::Compiler.AbstractInterpreter, ::Compiler.InferenceState)"
},
"children": [
]
},
{
"method_instance": {
"method": "finish_nocycle(::Compiler.AbstractInterpreter, frame::Compiler.InferenceState) @ Compiler ~/tmp/jl/julia-git/Compiler_ssair_lift_svec_ref_closure_type_stability/usr/share/julia/Compiler/src/typeinfer.jl:200",
"method_instance": "MethodInstance for Compiler.finish_nocycle(::Compiler.NativeInterpreter, ::Compiler.InferenceState)"
},
"children": [
]
}
]
}
]
}
]
}
]
},
{
"method_instance": {
"method": "sroa_pass!(ir::Compiler.IRCode, inlining::Union{Nothing, Compiler.InliningState}) @ Compiler ../usr/share/julia/Compiler/src/ssair/passes.jl:1212",
"method_instance": "MethodInstance for Compiler.sroa_pass!(::Compiler.IRCode, ::Compiler.InliningState{Compiler.NativeInterpreter})"
},
"children": [
{
"method_instance": {
"method": "run_passes_ipo_safe(ci::Core.CodeInfo, sv::Compiler.OptimizationState, optimize_until) @ Compiler ~/tmp/jl/julia-git/Compiler_ssair_lift_svec_ref_closure_type_stability/usr/share/julia/Compiler/src/optimize.jl:1036",
"method_instance": "MethodInstance for Compiler.run_passes_ipo_safe(::Core.CodeInfo, ::Compiler.OptimizationState{Compiler.NativeInterpreter}, ::Nothing)"
},
"children": [
{
"method_instance": {
"method": "run_passes_ipo_safe(ci::Core.CodeInfo, sv::Compiler.OptimizationState) @ Compiler ~/tmp/jl/julia-git/Compiler_ssair_lift_svec_ref_closure_type_stability/usr/share/julia/Compiler/src/optimize.jl:1036",
"method_instance": "MethodInstance for Compiler.run_passes_ipo_safe(::Core.CodeInfo, ::Compiler.OptimizationState{Compiler.NativeInterpreter})"
},
"children": [
{
"method_instance": {
"method": "optimize(interp::Compiler.AbstractInterpreter, opt::Compiler.OptimizationState, caller::Compiler.InferenceResult) @ Compiler ~/tmp/jl/julia-git/Compiler_ssair_lift_svec_ref_closure_type_stability/usr/share/julia/Compiler/src/optimize.jl:1015",
"method_instance": "MethodInstance for Compiler.optimize(::Compiler.NativeInterpreter, ::Compiler.OptimizationState{Compiler.NativeInterpreter}, ::Compiler.InferenceResult)"
},
"children": [
{
"method_instance": {
"method": "typeinf_frame(interp::Compiler.AbstractInterpreter, mi::Core.MethodInstance, run_optimizer::Bool) @ Compiler ~/tmp/jl/julia-git/Compiler_ssair_lift_svec_ref_closure_type_stability/usr/share/julia/Compiler/src/typeinfer.jl:1065",
"method_instance": "MethodInstance for Compiler.typeinf_frame(::Compiler.NativeInterpreter, ::Core.MethodInstance, ::Bool)"
},
"children": [
]
}
]
}
]
}
]
}
]
},
{
"method_instance": {
"method": "sroa_pass!(ir::Compiler.IRCode, inlining::Union{Nothing, Compiler.InliningState}) @ Compiler ../usr/share/julia/Compiler/src/ssair/passes.jl:1212",
"method_instance": "MethodInstance for Compiler.sroa_pass!(::Compiler.IRCode, ::Nothing)"
},
"children": [
{
"method_instance": {
"method": "sroa_pass!(ir::Compiler.IRCode) @ Compiler ../usr/share/julia/Compiler/src/ssair/passes.jl:1212",
"method_instance": "MethodInstance for Compiler.sroa_pass!(::Compiler.IRCode)"
},
"children": [
]
}
]
}
]
}
]
}
]
},
{
"method_instance": {
"method": "any(f::Function, a::AbstractArray; dims) @ Base reducedim.jl:989",
"method_instance": "MethodInstance for any(::Function, ::UnitRange{Int64})"
},
"children": [
]
}
]
}
]
}
]
}
]
}
]
}
]
}
]
}
]
} |
|
bump |
aviatesk
reviewed
Mar 11, 2025
|
As explained in discussion on sibling PR #57631, the issue is that it's known to be something equal to a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the closure capture a
SimpleVectorinstead of a type should improve type stability. Also deduplicated some common subexpressions while at it.