Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform.h: Always compile in MSVC mode if _MSC_VER is set #57680

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

romanrexc
Copy link
Contributor

This fixes embedding Julia on Windows when compiling with clang-cl.

This fixes embedding Julia on Windows when compiling with clang-cl.
@giordano giordano added the system:windows Affects only Windows label Mar 8, 2025
@ViralBShah
Copy link
Member

@barche Thoughts here?

@barche
Copy link
Contributor

barche commented Mar 11, 2025

I have never tried clang-cl, but I can imagine the old logic would break it, and this fix only changes the logic for the specific case of clang-cl, so this should be fine!

@romanrexc
Copy link
Contributor Author

It breaks it here:

In file included from julia-win64\include\julia\julia.h:20:
In file included from julia-win64\include\julia\libsupport.h:12:
julia-win64\include\julia\ios.h(88,30): error: unknown type name 'ios_t'
   88 | JL_DLLEXPORT size_t ios_read(ios_t *s, char *dest, size_t n) JL_NOTSAFEPOINT;

@ViralBShah ViralBShah merged commit 840923a into JuliaLang:master Mar 11, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system:windows Affects only Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants