Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errorshow: typeassert ::SimpleVector in _collapse_repeated_frames #57691

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nsajko
Copy link
Contributor

@nsajko nsajko commented Mar 9, 2025

Reduces the invalidation count on loading the package TypeDomainNaturalNumbers v6.1.0 from 980 to 968.

Reduces the invalidation count on loading the package
TypeDomainNaturalNumbers v6.1.0 from 980 to 968.
@nsajko
Copy link
Contributor Author

nsajko commented Mar 9, 2025

The invalidations fixed by this change:

{
    "method_instance": {
        "method": "_collapse_repeated_frames(trace) @ Base errorshow.jl:885",
        "method_instance": "MethodInstance for Base._collapse_repeated_frames(::Vector{Any})"
    },
    "children": [
        {
            "method_instance": {
                "method": "var\"#process_backtrace#830\"(skipC, ::typeof(Base.process_backtrace), t::Vector, limit::Int64) @ Base errorshow.jl:949",
                "method_instance": "MethodInstance for Base.var\"#process_backtrace#830\"(::Bool, ::typeof(Base.process_backtrace), ::Vector{Base.StackTraces.StackFrame}, ::Int64)"
            },
            "children": [
                {
                    "method_instance": {
                        "method": "process_backtrace(t::Vector, limit::Int64; skipC) @ Base errorshow.jl:949",
                        "method_instance": "MethodInstance for Base.process_backtrace(::Vector{Base.StackTraces.StackFrame}, ::Int64)"
                    },
                    "children": [
                        {
                            "method_instance": {
                                "method": "process_backtrace(t::Vector; ...) @ Base errorshow.jl:949",
                                "method_instance": "MethodInstance for Base.process_backtrace(::Vector{Base.StackTraces.StackFrame})"
                            },
                            "children": [
                                {
                                    "method_instance": {
                                        "method": "show_backtrace(io::IO, t::Vector) @ Base errorshow.jl:814",
                                        "method_instance": "MethodInstance for Base.show_backtrace(::IOContext{IO}, ::Vector{Base.StackTraces.StackFrame})"
                                    },
                                    "children": [
                                        {
                                            "method_instance": {
                                                "method": "verify_print_error(io::IOContext{IO}, desc::Base.Compiler.TrimVerifier.CallMissing, parents::IdDict{Core.CodeInstance, Tuple{Core.CodeInstance, Int64}}) @ Base.Compiler.TrimVerifier ~/tmp/jl/julia-git/invalidations_build/usr/share/julia/Compiler/src/verifytrim.jl:110",
                                                "method_instance": "MethodInstance for Base.Compiler.TrimVerifier.verify_print_error(::IOContext{IO}, ::Base.Compiler.TrimVerifier.CallMissing, ::IdDict{Core.CodeInstance, Tuple{Core.CodeInstance, Int64}})"
                                            },
                                            "children": [
                                            ]
                                        }
                                    ]
                                }
                            ]
                        }
                    ]
                }
            ]
        },
        {
            "method_instance": {
                "method": "var\"#process_backtrace#830\"(skipC, ::typeof(Base.process_backtrace), t::Vector, limit::Int64) @ Base errorshow.jl:949",
                "method_instance": "MethodInstance for Base.var\"#process_backtrace#830\"(::Bool, ::typeof(Base.process_backtrace), ::Vector{Union{Ptr{Nothing}, Base.InterpreterIP}}, ::Int64)"
            },
            "children": [
                {
                    "method_instance": {
                        "method": "process_backtrace(t::Vector, limit::Int64; skipC) @ Base errorshow.jl:949",
                        "method_instance": "MethodInstance for Base.process_backtrace(::Vector{Union{Ptr{Nothing}, Base.InterpreterIP}}, ::Int64)"
                    },
                    "children": [
                        {
                            "method_instance": {
                                "method": "process_backtrace(t::Vector; ...) @ Base errorshow.jl:949",
                                "method_instance": "MethodInstance for Base.process_backtrace(::Vector{Union{Ptr{Nothing}, Base.InterpreterIP}})"
                            },
                            "children": [
                                {
                                    "method_instance": {
                                        "method": "show_backtrace(io::IO, t::Vector) @ Base errorshow.jl:814",
                                        "method_instance": "MethodInstance for Base.show_backtrace(::IO, ::Vector{Union{Ptr{Nothing}, Base.InterpreterIP}})"
                                    },
                                    "children": [
                                        {
                                            "method_instance": {
                                                "method": "_atexit(exitcode::Int32) @ Base initdefs.jl:443",
                                                "method_instance": "MethodInstance for Base._atexit(::Int32)"
                                            },
                                            "children": [
                                            ]
                                        },
                                        {
                                            "method_instance": {
                                                "method": "_postoutput() @ Base initdefs.jl:489",
                                                "method_instance": "MethodInstance for Base._postoutput()"
                                            },
                                            "children": [
                                            ]
                                        }
                                    ]
                                }
                            ]
                        }
                    ]
                }
            ]
        }
    ]
}

@nsajko nsajko added error messages Better, more actionable error messages backport 1.12 Change should be backported to release-1.12 backport 1.11 Change should be backported to release-1.11 and removed backport 1.11 Change should be backported to release-1.11 labels Mar 9, 2025
@nsajko
Copy link
Contributor Author

nsajko commented Mar 11, 2025

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.12 Change should be backported to release-1.12 error messages Better, more actionable error messages invalidations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant