-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP/DNM]make similar produce the right chunktype #175
base: master
Are you sure you want to change the base?
Conversation
Could you please fix similar to give the right distribution while you are at it :) This doesn't work:
Which breaks copy, and may other constructs. Thank you! |
src/darray.jl
Outdated
@@ -240,17 +240,24 @@ end | |||
# new DArray similar to an existing one | |||
DArray(init, d::DArray) = DArray(next_did(), init, size(d), procs(d), d.indices, d.cuts) | |||
|
|||
Base.size(d::DArray) = d.dims | |||
chunktype(d::DArray{<:Any,<:Any,A}) where A = A | |||
arraykind(::Type{<:Array}) = Array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@r-barnes if we add arraykind(::Type{T}) where T >: Array = Array
the promote_type
idea in #180 (comment) might just work. I won't have time until mid-October to look at that in earnest though so please go ahead and experiment.
This reverts commit 960f605.
This has become a pile of various changes I needed for a project, I will separate them out as well as cleaning them up. |
Closing because its old. |
Not that old :) and I would keep it open as a reminder to myself that this work needs to get cleaned up and finished or migrated over to Dagger. |
Defaulting to Array breaks a mat * vec of DArray{CuArray}