Fix modifying(!) functions not updating SyncPlots in Jupyter #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plotly mime appears to have a higher precedence (due to IJulia or the presence of the plotly jupyter extension) which prevents the WebIO scope from being rendered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on JuliaGizmos/WebIO.jl #497 and/or JuliaGizmos/WebIO.jl #498.
For a while now, plot modifying functions (e.g.
add_vline!, etc) did not actually update the existing plot in Jupyter, and the plot needed to be redisplayed to see any changes.I discover that the plotly mime type appears to have a higher precedence in Jupyter (unclear if this is due to the jupyterlab-plotly extension or something in IJulia), and that the definition of an
IJulia.display_dictmethod also interfered with rendering the WebIO scope (and instead resulted in the [false] default warning that WebIO was not detected, when it is in fact correctly installed and detected/functioning).Without my WebIO PR's, plots won't update yet in Jupyter, but the WebIO rendered scope is now showing properly, and the other mime types are still present in the notebook/cell outputs "data" field (in order, `["application/vnd.webio.node+json", "image/png", "image/svg+xml", "text/html", "text/plain"]).