-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: ROOT2 v0.1.0 #108073
New package: ROOT2 v0.1.0 #108073
Conversation
JuliaRegistrator
commented
Jun 1, 2024
•
edited
Loading
edited
- Registering package: ROOT2
- Repository: https://github.com/JuliaHEP/ROOT2
- Created by: @grasph
- Version: v0.1.0
- Commit: 9169d44f3b8e8e2334449b679d0b5949500e5f04
- Reviewed by: @grasph
- Reference: package registration JuliaHEP/ROOT2#1 (comment)
- Description: Interface to the ROOT analysis framewok
- Release notes:
UUID: 4e771be0-af1c-4c60-a3da-ec998561eab7 Repo: https://github.com/JuliaHEP/ROOT2.git Tree: acc42fb275e3b52aee68d82e3a4dd5002a8f13e2 Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
911cdf4
to
9b8f555
Compare
Your
Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text |
automerge/decision complains the package name, The name has been chosen after the name of the C++ framework ROOT to which this package provides Julia bindings. The suffix '2' is there to distinguish it from Let me know if we can keep this name or if we need to invent a new one. |
Agreed on But it's unfortunate to have |
Latest ROOT.jl development were done by @oschulz. The two packages use different approaches and have their own limitations: one is limited to some old Julia releases and this other is limited to a subset of the c++ framework classes. If Cxx.jl development is eventually resumed and support to recent Julia release added, then the ROOT.jl limitation will vanish. So I think we should keep both packages, but I will be happy to hear @oschulz and @jpata's views. |
ROOT2.jl looks to be using a conceptually similar approach as the original ROOT.jl based on wrappers. Therefore, it could make sense as a new version of the old package to not confuse the ecosystem too much. I'm not maintaining ROOT.jl and would be happy to give it over to a group that's interested in maintaining it. FYI @Moelf |
@grasph, I would also vote for replacing the old ROOT.jl (originally created by @jpata and later maintained by me) instead of creating a ROOT2.jl. ROOT.jl was based on Cxx.jl, which has been non-functional on maintained Julia versions for a long time. @grasph I'm giving you full admin rights on the ROOT.jl repo. |
Note: ROOT.jl is currently not registered anymore (it was in pre-Pkg3-times), but for continuity reasons we may still want to label the new version v0.3.0 instead of going back to v0.1.0 (@giordano , do you have any preferences here?). @grasph , please feel free to completely replace the current contents of the ROOT.jl repo with your CxxWrap-based version. |
OK. Then, I will move the code to the ROOT.jl repository, change the version to 0.3.0, and trigger a new PR from there. Thanks @goerz to have made the suggestion. |
Yeah, maybe ROOT.jl is slightly better: since there's currently no registered ROOT.jl, ROOT2.jl looks a bit surprising to users.
Side note, it's complaining also about many other things, like missing compat bounds. |
Replaced by #108095. |