-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add x + conj(x) rule #530
base: master
Are you sure you want to change the base?
Add x + conj(x) rule #530
Conversation
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Fine with this, could you add a test or two? |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #530 +/- ##
=======================================
Coverage 81.19% 81.19%
=======================================
Files 15 15
Lines 1856 1856
=======================================
Hits 1507 1507
Misses 349 349
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Done. Also added a couple more rules (correct ones this time 😅). |
Just curious @shashi is there an |
@MilesCranmer No I don't think so, but it could be added. |
Looks like the tests I added are passing now. I guess the segfault is a more general issue? |
@shashi The reason I asked about the |
(It could just be measurement uncertainty in the benchmarks though?? Not sure. Probably worth a local benchmark to be sure) |
Not sure if this is the right thing to do, but a PR seemed like the easiest way to bring this up.