Data source apstra_blueprint_device_rendered_config no error on incremental config 404
#964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwJuniper
approved these changes
Nov 5, 2024
chrismarget-j
deleted the
962-apstra_blueprint_device_rendered_config-data-source-404-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API endpoints used by
apstra_blueprint_device_rendered_configreturn 404 when the node or system in question appears only in the staging config.Requesting an incremental config between "staged" (with device assigned) and "deployed" (no device assigned) does not work.
Rather than surfacing an error early in the deployment lifecycle, this PR changes the behavior so that we return
Nullfor these values.Also, cleaned up some problematic test
sync.WaitGroupcode which has been causing intermittent test failures. Much simpler now.Closes #962