Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ 使部分接口返回用户数据 #15

Merged
merged 6 commits into from
Aug 26, 2024
Merged

✨ 使部分接口返回用户数据 #15

merged 6 commits into from
Aug 26, 2024

Conversation

YasaitoriOvO
Copy link
Member

No description provided.

@YasaitoriOvO YasaitoriOvO mentioned this pull request Aug 25, 2024
Open
@YasaitoriOvO YasaitoriOvO changed the title 🐛 修复评论不返回昵称 ✨ 使部分接口返回用户数据 Aug 26, 2024
@YasaitoriOvO YasaitoriOvO mentioned this pull request Aug 26, 2024
Open
otomad
otomad requested changes Aug 26, 2024
View reviewed changes
Copy link
Member

@otomad otomad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 只有 UUID 可不行，还需要提供 UID。
  2. 代码中：UUID → uuid 。注释中不变。

src/controller/DanmakuControllerDto.d.ts Outdated Show resolved Hide resolved
src/service/DanmakuService.ts Outdated Show resolved Hide resolved
otomad
otomad requested changes Aug 26, 2024
View reviewed changes
Copy link
Member

@otomad otomad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

捉个虫，修改后即通过。

src/controller/DanmakuControllerDto.d.ts Outdated Show resolved Hide resolved
@YasaitoriOvO
Copy link
Member Author

那我close issue了？

@otomad
Copy link
Member

otomad commented Aug 26, 2024

那我close issue了？

你应该在 commit 提交的时候写上

Fix #xx

来直接关闭议题。

不过前端部分还需要把 dto 复制过去，这还没算完成。

@YasaitoriOvO
Copy link
Member Author

那我close issue了？

你应该在 commit 提交的时候写上

Fix #xx

来直接关闭议题。

不过前端部分还需要把 dto 复制过去，这还没算完成。

了解

@otomad otomad merged commit 36ed71e into KIRAKIRA-DOUGA:develop Aug 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otomad otomad otomad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YasaitoriOvO @otomad