Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a custom Github action for setting up the SMT solvers #3569

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

wadoon
Copy link
Member

@wadoon wadoon commented Feb 23, 2025

Intended Change

Exchange of the dlsmt.sh scripts in favor of a real Github action that uses Github's API for setting up the SMT solvers.

This action is self-written and available here: https://github.com/KeYProject/setup-smt

Benefit: The pipeline becomes OS-independent and now we can run macOS and windows pipelines with SMT solvers. This PR also enables SMT solvers on windows unit-test pipelines!

On the road: Fixes for double artifact names on 8our broad release tests](https://github.com/KeYProject/key/actions/workflows/tests_winmac.yml).

Type of pull request

Ensuring quality

  • I have tested the feature as follows: CI

I currently have only added z3 and CVC5 to setup-smt as these were also in dlsmt.sh. Looking at java-smt3 the following exists:

Please add a PR at keyproject/setup-smt if some of these are required.

@wadoon wadoon marked this pull request as ready for review February 23, 2025 17:53
@wadoon wadoon requested a review from Drodt February 23, 2025 18:00
@wadoon wadoon self-assigned this Feb 23, 2025
@wadoon wadoon added Infrastructure Changes to the Github configurations, repository or other non-source stuff CI 🛠 Maintenance Code quality and related things w/o functional changes labels Feb 23, 2025
@wadoon wadoon added this to the v2.12.4 milestone Feb 23, 2025
@wadoon wadoon force-pushed the weigl/cleanup/dlsmt branch from 5d728da to 785c4db Compare February 23, 2025 18:02
@wadoon wadoon enabled auto-merge February 23, 2025 18:10
@wadoon wadoon force-pushed the weigl/cleanup/dlsmt branch from a626457 to 433a0cb Compare February 24, 2025 19:21
@wadoon wadoon requested review from WolframPfeifer and removed request for Drodt February 25, 2025 15:28
@wadoon
Copy link
Member Author

wadoon commented Feb 25, 2025

Strange: Unit tests succeed on windows, but not on Linux.

Error on Linux is:

unit-tests (ubuntu-latest, 21)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

This happens after 25 min. The Windows run needs 45 min. to complete.

@WolframPfeifer @mattulbrich We might hit a memory boundary limit here. Do we have experience with z3 4.14 and cvc5 1.2.1? I would remove the later one from the pipeline for testing.

@wadoon wadoon force-pushed the weigl/cleanup/dlsmt branch 2 times, most recently from fee0fc9 to c1ca980 Compare February 28, 2025 14:35
@wadoon wadoon force-pushed the weigl/cleanup/dlsmt branch from c1ca980 to 6da0f62 Compare February 28, 2025 14:36
@wadoon
Copy link
Member Author

wadoon commented Feb 28, 2025

From KaKeY:

  • #testDiv5 and '#testDiv6' are deactivated as their runtime hit the timeout (total of 10 min. runtime). They are probably the cause of the unexpected shutdown problems on Linux runners.

Issues: #3575

@wadoon wadoon force-pushed the weigl/cleanup/dlsmt branch from 6da0f62 to 86064c7 Compare February 28, 2025 15:27
@mattulbrich
Copy link
Member

We agreed to keep the two cases with shorter timeout. Since the timeout can unfortunately not be set individually for test cases but is driven by a special settings class, the overhead is not worth it and we keep them deactivated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Infrastructure Changes to the Github configurations, repository or other non-source stuff 🛠 Maintenance Code quality and related things w/o functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants