Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the build command for OLC #122

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ install_hooks() {

install_our_lovely_cli() {
cd "$DEVTOOLS_DIR/our-lovely-cli"
npm install
make all
Comment on lines 319 to +320
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that you're using make, a better alternative is to just do:

make -C "$DEVTOOLS_DIR/our-lovely-cli" all

Then we don't have to do the cd, which is always nice to avoid in shell scripts.

}

check_dependencies
Expand Down