Remove z-index tokens, constants, and classes that place SOME widgets above the doodlepad. #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll do some testing once I get an npm artifact. |
…long-standing bugs in consuming code.
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (7f8abaf) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2170If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2170 |
|
Size Change: -38 B (0%) Total Size: 1.48 MB
ℹ️ View Unchanged
|
nedredmond
commented
Jan 29, 2025
| @@ -416,7 +416,7 @@ class Graph extends React.Component<Props> { | |||
|
|
|||
| return ( | |||
| <div | |||
| className="graphie-container above-scratchpad" | |||
| className="graphie-container blank-background" | |||
There was a problem hiding this comment.
Swapped because above-scratchpad adds blank-background styles in perseus-renderer.less
nedredmond
commented
Jan 29, 2025
| @@ -161,7 +161,7 @@ class Measurer extends React.Component<Props> implements Widget { | |||
| <div | |||
| className={ | |||
| "perseus-widget perseus-widget-measurer " + | |||
| "graphie-container above-scratchpad" | |||
| "graphie-container blank-background" | |||
There was a problem hiding this comment.
Here too, ensuring we don't lose nested styles
|
whoops my branch is completely mis-named. oh well |
|
Works as expected! Screen.Recording.2025-01-30.at.11.55.58.AM.mov |
|
@MikeKlemarewski added you mostly as FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I did this in two passes -- one commit to remove
above scratchpad, and a second forinteractive, which seems to be used for the same purpose. Both place widgets above thescratchpaddoodlepad, which has long led to many bugs.Issue: TUT-1059