Add -all option to 'yarn clean' #2176
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (86d2184) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2176If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2176 |
|
Size Change: 0 B Total Size: 1.48 MB ℹ️ View Unchanged
|
jeremywiebe
changed the title
jeremywiebe
requested review from
SonicScrewdriver,
mark-fitzgerald,
Myranae,
catandthemachines and
a team
jeremywiebe
commented
Jan 31, 2025
| CLEAN_ALL=false | ||
| while [[ $# -gt 0 ]]; do | ||
| case $1 in | ||
| -a|--all) |
There was a problem hiding this comment.
We could probably make an argument for not having an option at all and just deleting all node_modules folder always.
What say you?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We've had instances where folks' local repo gets into a bad state. It's assumed that
yarn cleanwill resolve this, but it hasn't in all cases because it doesn't deletenode_modules.This PR adds a
--alloption toyarn cleanto demolish allnode_modulesfolders in the local repo.Issue: "none"
Test plan:
yarnyarn cleanls node_modules# still existsyarn clean --allfind . -name node_modules -and -type d# no results!