Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarification for GLSL_EXT_buffer_reference forward declaration #265

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Clarification for GLSL_EXT_buffer_reference forward declaration #265

merged 2 commits into from
Feb 17, 2025

Conversation

spencer-lunarg
Copy link
Contributor

Noticed in KhronosGroup/glslang#3774 that going

layout(buffer_reference, std140, buffer_reference_align = 8) buffer MyStruct;
layout(buffer_reference) buffer MyStruct {  vec4 x;  };

the std140 and buffer_reference_align are ignored but it is not obvious and added clarification

@pdaniell-nv pdaniell-nv added the Vulkan Functionality applies to Vulkan API label Nov 5, 2024
@gnl21 gnl21 requested a review from jeffbolznv November 22, 2024 11:48
@spencer-lunarg
Copy link
Contributor Author

Can we merge this in so I can rebase #277 on top of it

@gnl21 gnl21 merged commit 9d7a345 into KhronosGroup:main Feb 17, 2025
1 check passed
@spencer-lunarg spencer-lunarg deleted the patch-1 branch February 17, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnl21 gnl21 gnl21 left review comments

@jeffbolznv jeffbolznv jeffbolznv approved these changes

Assignees
No one assigned
Labels
Vulkan Functionality applies to Vulkan API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spencer-lunarg @jeffbolznv @gnl21 @pdaniell-nv