Validation for relaxed control barrier with storage class semantics #5984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Natalia Gavrilenko <[email protected]>
alan-baker
reviewed
Feb 10, 2025
| if (opcode == spv::Op::OpControlBarrier && value) { | ||
| if (!num_memory_order_set_bits) { | ||
| return _.diag(SPV_ERROR_INVALID_DATA, inst) | ||
| << _.VkErrorID(4649) << spvOpcodeString(opcode) |
There was a problem hiding this comment.
This VUID does not exist. There needs to be a Vulkan-Docs PR to add this rule, at which point a VUID will be assigned.
There was a problem hiding this comment.
Created this one KhronosGroup/Vulkan-Docs#2495
There was a problem hiding this comment.
it might take awhile (like 2 or 3 weeks) to get the VUID in and upstreamed, I am happy to come back here and apply it, but for the short term, just remove VkErrorID() here, and the 4649 stuff everywhere else
There was a problem hiding this comment.
I think waiting 2–3 weeks should be fine. The main change in this PR is adding a new validation rule, and without the new VUID, there wouldn’t be much left.
natgavrilenko
pushed a commit
to natgavrilenko/Vulkan-Docs
that referenced
this pull request
Feb 11, 2025
Add a new VUID for a relaxed control barrier with non-zero storage class semantics. PR in SPIRV-Tools: KhronosGroup/SPIRV-Tools#5984 Signed-off-by: Natalia Gavrilenko <[email protected]>
natgavrilenko
added a commit
to natgavrilenko/Vulkan-Docs
that referenced
this pull request
Feb 11, 2025
Add a new VUID for a relaxed control barrier with non-zero storage class semantics. PR in SPIRV-Tools: KhronosGroup/SPIRV-Tools#5984 Signed-off-by: Natalia Gavrilenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit aligns OpControlBarrier semantics validation with the Vulkan memory model. It disallows combining a relaxed memory order with non-zero storage class semantics in the Vulkan target environment. To my knowledge, this combination is not generated by any compiler.