spirv-val: Check DebugLine Line/Column are valid

[spencer-lunarg]

I had to raise issue in Glslang because it would generate Line/Column that didn't actually point to any valid spot in the DebugSource's text

This adds some validation where if there is a DebugSource with Text then any Line/Column must be correct, otherwise every other consume tool (like Validation Layers) need to do this before trying to print out the snippet in the source code

[spencer-lunarg]

It seems these tests are showing the bug I found in GLSL (KhronosGroup/glslang#3863), where things like https://github.com/KhronosGroup/glslang/blob/main/Test/baseResults/spv.debuginfo.implicit_br.glsl.frag.out#L16 are adding extra things to the source, but not updating the Line number to match it

[alan-baker]

Seems ok for the most part. Prefer making the accessor more robust generally.

For my own sake, I think DebugSourceContinued can't ever be used as a 'Source' operand so all the lines and columns are relative to a DebugSource instruction.

[spencer-lunarg]

For my own sake, I think DebugSourceContinued can't ever be used as a 'Source' operand so all the lines and columns are relative to a DebugSource instruction.

That is correct, we will always reference the DebugSource, but the Text operand in DebugSource might be incomplete, so we need to build it up to find the DebugSourceContinued after it

[alan-baker]

Looks ok, but I've restarted the formatting bot.

[spencer-lunarg]

@alan-baker what did we want to do with Glslang failing, should I try to push and get those fixes in first and then rebase this? (I know we have a protocol for these situations, I just haven't had to do it in awhile)

[alan-baker]

@alan-baker what did we want to do with Glslang failing, should I try to push and get those fixes in first and then rebase this? (I know we have a protocol for these situations, I just haven't had to do it in awhile)

You can either fix glslang first if you want or merge this and update glslang to have failing tests until it is fixed. If glslang can be updated first, that's preferable.