Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #338

Closed
wants to merge 11 commits into from
Closed

Update #338

wants to merge 11 commits into from

Conversation

Justman100
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jan 28, 2024

CLA assistant check
All committers have signed the CLA.

@Justman100
Copy link
Author

@saisatishkarra

@itsikcircle
Copy link
Contributor

You should also update .github/workflows/build.yml to test this version

@itsikcircle
Copy link
Contributor

For the meantime, until this package is published, I've published a fork with the node engine changes:
https://www.npmjs.com/package/@itsikm/httpsnippet

@Justman100
Copy link
Author

@saisatishkarra

package.json Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why'd this get deleted?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because superfluous?

@Justman100
Copy link
Author

@filfreire

@filfreire
Copy link
Member

Thank you for the PR, we will handle this in a separate one

@filfreire filfreire closed this Jul 12, 2024
@Justman100
Copy link
Author

Thank you for the PR, we will handle this in a separate one

Are you kidding me? Instead of just merging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants