-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(keys): add a new field x5t
to the entity keys
#14154
Open
catbro666
wants to merge
8
commits into
master
Choose a base branch
from
fti-6399-keys-entity-adds-x5t
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b27d349
to
a330557
Compare
liverpool8056
requested changes
Jan 23, 2025
9215634
to
37aa18d
Compare
windmgc
approved these changes
Feb 25, 2025
ms2008
approved these changes
Feb 27, 2025
37aa18d
to
28c03d6
Compare
liverpool8056
approved these changes
Feb 27, 2025
28c03d6
to
722e766
Compare
722e766
to
22f6410
Compare
bungle
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
core/clustering
core/db/migrations
core/db
schema-change-noteworthy
size/L
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
jwe-decrypt plugin wants to support searching key by x5t, so there's this PR. This PR adds a new field
x5t
for thekeys
entity. And similar to thekid
, thex5t
andset_id
combination should be unique.One customer is using Azure to generate JWE token and the protected header of a JWE token generated by Azure is as below:
It uses
x5t
field instead ofkid
field and the enc is A128CBC-HS256. So customer is requesting jwe-decrypt plugin to support searching key by the x5t field.Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
https://konghq.atlassian.net/browse/FTI-6399