Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clustering/rpc): process ws_id correctly (#11547) #14356

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix(clustering/rpc): process ws_id correctly (#11547) #14356

wants to merge 2 commits into from

Conversation

chobits
Copy link
Contributor

@chobits chobits commented Mar 12, 2025 •
edited by ADD-SP
Loading

cherry-pick to Kong-ce from EE pr: https://github.com/Kong/kong-ee/pull/11547

We need to follow the RPC spec to handle ws_id.

  1. set entity/delta ws_id correctly when initially inserting delta to Database
  2. correct get detal key logic for coalesing

KAG-6432

Summary

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@chobits @chronolaw
fix(clustering/rpc): process ws_id correctly (#11547)
30f8f55 
We need to follow the RPC spec to handle ws_id, see this: https://github.com/Kong/openrpc_specfiles/blob/be7b56fd9bd75245e267d0cd2638ec9ea740f049/kong_sync/v2/kong.sync.yaml#L259

1. set entity/delta ws_id correctly when initially inserting delta to Database
2. correct get detal key logic for coalesing

KAG-6432

---------

Co-authored-by: Chrono <[email protected]>
@github-actions github-actions bot added schema-change-noteworthy cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Mar 12, 2025
@chobits chobits removed the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Mar 12, 2025
@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Mar 12, 2025
@chobits chobits marked this pull request as draft March 12, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chronolaw chronolaw chronolaw approved these changes

@Oyami-Srk Oyami-Srk Oyami-Srk approved these changes

@StarlightIbuki StarlightIbuki StarlightIbuki approved these changes

Assignees

@chobits chobits

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering core/db schema-change-noteworthy size/S skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chobits @chronolaw @Oyami-Srk @StarlightIbuki