fix(translator): Only log error for duplicate SNI when the certificate ID are not the same #7147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Emit error log only when two certificates does not have the same ID but has duplicate SNI.
Resolves FTI-6500.
Which issue this PR fixes:
Special notes for your reviewer:
The
current.snis = append(current.snis, cw.snis...)
looks not useful. thesni
field ofcertWrapper
is not used in further translation and the SNIs of the current certificate are processed in thefor _, cert := range cw.snis {...}
. So I deleted it in the PR.Since the code is too old (originally from #2580), please take a look if I have missed any context.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR