Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(translator): Only log error for duplicate SNI when the certificate ID are not the same #7147

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

randmonkey
Copy link
Contributor

What this PR does / why we need it:

Emit error log only when two certificates does not have the same ID but has duplicate SNI.
Resolves FTI-6500.

Which issue this PR fixes:

Special notes for your reviewer:

The current.snis = append(current.snis, cw.snis...) looks not useful. the sni field of certWrapper is not used in further translation and the SNIs of the current certificate are processed in the for _, cert := range cw.snis {...}. So I deleted it in the PR.
Since the code is too old (originally from #2580), please take a look if I have missed any context.
PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey requested a review from a team as a code owner February 20, 2025 10:26
@randmonkey randmonkey self-assigned this Feb 20, 2025
@randmonkey randmonkey added this to the KIC v3.5.x milestone Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.8%. Comparing base (d4d18a4) to head (a8c9e49).
Report is 83 commits behind head on main.

Files with missing lines Patch % Lines
internal/dataplane/translator/translate_certs.go 0.0% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #7147     +/-   ##
=======================================
- Coverage   76.9%   76.8%   -0.1%     
=======================================
  Files        214     213      -1     
  Lines      25169   24976    -193     
=======================================
- Hits       19356   19187    -169     
+ Misses      4794    4790      -4     
+ Partials    1019     999     -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant