Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump deps and align APIs to match KGO #7156

Draft
wants to merge 1 commit into
base: feat/kic-as-library
Choose a base branch
from

Conversation

czeslavo
Copy link
Contributor

What this PR does / why we need it:

Bumps kong/kubernetes-configuration module dependency to the commit used in KGO. Changes manager's Run to Start to satisfy controller-runtime's Runnable interface.

Which issue this PR fixes:

Part of Kong/gateway-operator#1172.

@czeslavo czeslavo force-pushed the chore/bump-deps-for-kgo branch from 06121d1 to 0e034cd Compare February 21, 2025 08:20
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (feat/kic-as-library@d176d42). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ernal/controllers/utils/control_plane_reference.go 0.0% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             feat/kic-as-library   #7156   +/-   ##
=====================================================
  Coverage                       ?    4.0%           
=====================================================
  Files                          ?     145           
  Lines                          ?   15094           
  Branches                       ?       0           
=====================================================
  Hits                           ?     616           
  Misses                         ?   14411           
  Partials                       ?      67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo czeslavo force-pushed the chore/bump-deps-for-kgo branch from 0e034cd to 7528454 Compare February 21, 2025 10:31
@pull-request-size pull-request-size bot added size/L and removed size/M labels Feb 21, 2025
@czeslavo czeslavo force-pushed the chore/bump-deps-for-kgo branch from 7528454 to 0315f42 Compare February 21, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant