Sort df.compileTimeSchema() columns according to df.schema() so they're easier to compare #990
+88
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koperagen
force-pushed
the
compileTimeSchemaOrder
branch
from
3689c11 to
adca94b
Compare
Jolanrensen
reviewed
Jan 2, 2025
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api/schema.kt
Outdated
Show resolved
Hide resolved
Jolanrensen
reviewed
Jan 2, 2025
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api/schema.kt
Outdated
Show resolved
Hide resolved
Jolanrensen
requested changes
Jan 2, 2025
…re easier to compare
koperagen
force-pushed
the
compileTimeSchemaOrder
branch
from
adca94b to
791dfb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quality of life improvement. I print both schemas when i test implementation of join operation. I used to get compileTimeSchema in somewhat random order, it makes diff useless. Now when columns are present in both schemas, they will go in a definite order