Keywords generator plugin: moved and fixed for Kotlin 2.1 #996
+113
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lugin, bumping versions
Jolanrensen
added
the
infrastructure
koperagen
reviewed
Dec 12, 2024
| lateinit var srcDir: File | ||
|
|
||
| @Input | ||
| override fun getGroup() = "codegen" |
There was a problem hiding this comment.
Let's keep default group for this task? I don't think it deserves a group of its own
There was a problem hiding this comment.
I just copied this over from the old implementation. Shall I still remove it?
There was a problem hiding this comment.
it will be put in "other" if we don't supply a group (which is ginormous). Maybe a separate group for codegen stuff is not such a bad idea.
koperagen
reviewed
Dec 12, 2024
...ywords-generator/src/main/kotlin/org/jetbrains/dataframe/keywords/KeywordsGeneratorPlugin.kt
Outdated
Show resolved
Hide resolved
koperagen
reviewed
Dec 12, 2024
...ywords-generator/src/main/kotlin/org/jetbrains/dataframe/keywords/KeywordsGeneratorPlugin.kt
Outdated
Show resolved
Hide resolved
zaleslaw
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #899
This PR is required for updating to Kotlin 2.1 (#995)
:generatorplugin to worker-based:plugins:keywords-generatorplugin. This is required for Kotlin 2.1 to avoid tons of warnings. Explained here: https://kotlinlang.org/docs/whatsnew21.html#compiler-symbols-hidden-from-the-kotlin-gradle-plugin-apiWe should be able to merge this even before bumping to Kotlin 2.1