no message

LACNIC · Nov 4, 2024 · 2a176a4 · 2a176a4
1 parent f75f121
commit 2a176a4
Show file tree

Hide file tree

Showing 10 changed files with 12 additions and 12 deletions.
diff --git a/src/main/java/net/lacnic/portal/auth/client/MySSLSocketFactory.java b/src/main/java/net/lacnic/portal/auth/client/MySSLSocketFactory.java
@@ -2,7 +2,6 @@
 
 import java.io.IOException;
 import java.net.Socket;
-import java.net.UnknownHostException;
 import java.security.KeyManagementException;
 import java.security.KeyStore;
 import java.security.KeyStoreException;
@@ -39,7 +38,7 @@ public X509Certificate[] getAcceptedIssuers() {
 	}
 
 	@Override
-	public Socket createSocket(Socket socket, String host, int port, boolean autoClose) throws IOException, UnknownHostException {
+	public Socket createSocket(Socket socket, String host, int port, boolean autoClose) throws IOException {
 		return sslContext.getSocketFactory().createSocket(socket, host, port, autoClose);
 	}
 

diff --git a/src/main/java/net/lacnic/portal/auth/client/PortalWSClient.java b/src/main/java/net/lacnic/portal/auth/client/PortalWSClient.java
@@ -123,7 +123,7 @@ private static String readUrlToken(String urlString, String token) {
 		}
 	}
 
-	private static String getAuthToken() throws Exception {
+	private static String getAuthToken() {
 		Properties props = getPaiProperties();
 		return props.getProperty(PORTAL_APIKEY);
 	}

diff --git a/src/main/java/net/lacnic/portal/auth/client/Utils2FA.java b/src/main/java/net/lacnic/portal/auth/client/Utils2FA.java
@@ -19,6 +19,8 @@
 
 public class Utils2FA {
 
+	private static final String UTF_8 = "UTF-8";
+
 	public static String obtenerSecretKey(String user) {
 		try {
 			String secretKey = Utils2FA.generateSecretKey();
@@ -51,7 +53,7 @@ public static String getTOTPCode(String secretKey) {
 
 	public static String getGoogleAuthenticatorBarCode(String secretKey, String account, String issuer) {
 		try {
-			return "otpauth://totp/" + URLEncoder.encode(issuer + ":" + account, "UTF-8").replace("+", "%20") + "?secret=" + URLEncoder.encode(secretKey, "UTF-8").replace("+", "%20") + "&issuer=" + URLEncoder.encode(issuer, "UTF-8").replace("+", "%20");
+			return "otpauth://totp/" + URLEncoder.encode(issuer + ":" + account, UTF_8).replace("+", "%20") + "?secret=" + URLEncoder.encode(secretKey, UTF_8).replace("+", "%20") + "&issuer=" + URLEncoder.encode(issuer, UTF_8).replace("+", "%20");
 		} catch (UnsupportedEncodingException e) {
 			throw new IllegalStateException(e);
 		}

diff --git a/src/main/java/net/lacnic/portal/auth/client/UtilsLogin.java b/src/main/java/net/lacnic/portal/auth/client/UtilsLogin.java
@@ -19,8 +19,7 @@ public static LoginData login(String username, String password) {
 			byte[] bytes = md.digest();
 			String hash = new String(Base64.getEncoder().encode(bytes));
 			password = "{SHA256}" + hash;
-			LoginData infoLDAP = PortalWSClient.getLoginData(username, password);
-			return infoLDAP;
+			return PortalWSClient.getLoginData(username, password);
 		} catch (Exception e) {
 			logger.error("An error occurred: {}", e.getMessage(), e);
 			return new LoginData("Error: verifique usuario y/o contraseña");

diff --git a/src/test/java/net/lacnic/portal/auth/client/LoginDataTest.java b/src/test/java/net/lacnic/portal/auth/client/LoginDataTest.java
@@ -14,7 +14,7 @@
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
-public class LoginDataTest {
+class LoginDataTest {
 
 	private LoginData loginData;
 

diff --git a/src/test/java/net/lacnic/portal/auth/client/PortalHttpClientTest.java b/src/test/java/net/lacnic/portal/auth/client/PortalHttpClientTest.java
@@ -9,7 +9,7 @@
 import org.apache.http.params.HttpParams;
 import org.junit.jupiter.api.Test;
 
-public class PortalHttpClientTest {
+class PortalHttpClientTest {
 
 	@Test
 	void testGetNewHttpClient_returnsConfiguredHttpClient() {

diff --git a/src/test/java/net/lacnic/portal/auth/client/TokenDataTest.java b/src/test/java/net/lacnic/portal/auth/client/TokenDataTest.java
@@ -11,7 +11,7 @@
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
-public class TokenDataTest {
+class TokenDataTest {
 
 	private TokenData tokenData;
 

diff --git a/src/test/java/net/lacnic/portal/auth/client/Utils2FATest.java b/src/test/java/net/lacnic/portal/auth/client/Utils2FATest.java
@@ -23,7 +23,7 @@
 
 import de.taimos.totp.TOTP;
 
-public class Utils2FATest {
+class Utils2FATest {
 
 	@BeforeEach
 	void setUp() {

diff --git a/src/test/java/net/lacnic/portal/auth/client/UtilsFilesTest.java b/src/test/java/net/lacnic/portal/auth/client/UtilsFilesTest.java
@@ -15,7 +15,7 @@
 import org.junit.jupiter.api.Test;
 import org.mockito.Mockito;
 
-public class UtilsFilesTest {
+class UtilsFilesTest {
 
 	private static final String TEMP_DIR_KEY = "jboss.server.temp.dir";
 	private Path tempDirectory;

diff --git a/src/test/java/net/lacnic/portal/auth/client/UtilsLoginTest.java b/src/test/java/net/lacnic/portal/auth/client/UtilsLoginTest.java
@@ -16,7 +16,7 @@
 import org.junit.jupiter.api.Test;
 import org.mockito.MockedStatic;
 
-public class UtilsLoginTest {
+class UtilsLoginTest {
 
 	private HttpServletRequest mockRequest;