Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patches to ldmx-sw following compiler update #1640

Merged
merged 32 commits into from
Mar 5, 2025
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
3844ec2
mandatory patches for configure-quick build to finish
tomeichlersmith Feb 28, 2025
81fc132
Apply clang-format
github-actions[bot] Feb 28, 2025
3fbad73
dont need to inherit from std::iterator anymore in C++20
tomeichlersmith Feb 28, 2025
e623ef5
rename into config subdirectory
tomeichlersmith Feb 28, 2025
033c236
WIP: middle of Python refactor avoiding meaningless class
tomeichlersmith Feb 28, 2025
20d7cdb
Apply clang-format
github-actions[bot] Feb 28, 2025
c7b0c63
propagate Python refactor to tests
tomeichlersmith Mar 3, 2025
5fe1662
more precise deduction of dev image major version, patch python init
tomeichlersmith Mar 3, 2025
ae2f0f1
Apply clang-format
github-actions[bot] Mar 3, 2025
0a7690f
a bit more cleanup, don't need cmd anymore
tomeichlersmith Mar 3, 2025
6c45d31
patch typo in config clear statement
tomeichlersmith Mar 3, 2025
0ba5829
don't need special define anymore
tomeichlersmith Mar 3, 2025
821438c
cleanup run command
tomeichlersmith Mar 3, 2025
e48c547
patch up new PyConfig style of configuratoin
tomeichlersmith Mar 3, 2025
9363ff2
Apply clang-format
github-actions[bot] Mar 3, 2025
6857ec6
create object to avoid accessing an optimized-out move
tomeichlersmith Mar 3, 2025
c5cc89b
remove warning on checking for container
tomeichlersmith Mar 3, 2025
7f30c05
remove getDummy and dummy constructor
tomeichlersmith Mar 3, 2025
0c98b48
fix typo in copying to dereference confirmed non-null pointer
tomeichlersmith Mar 3, 2025
001034a
patch up dangling references in logger
tomeichlersmith Mar 3, 2025
12af7b0
flag a local variable as maybe unused
tomeichlersmith Mar 3, 2025
5ccab33
misplaced parenthesis caught since fabs(bool) doesnt make sense
tomeichlersmith Mar 3, 2025
9a04617
remove meaningless check, overlayEvent_ will never be NULL
tomeichlersmith Mar 3, 2025
4697425
trim dead code referencing particleIndex, use range-based for
tomeichlersmith Mar 3, 2025
2126686
Apply clang-format
github-actions[bot] Mar 3, 2025
3f39f30
more careful pointer handling in KaonPhysics::DumpDeayTable
tomeichlersmith Mar 3, 2025
a563a1d
check to make sure primaries are not NULL
tomeichlersmith Mar 3, 2025
be5eb9d
Apply clang-format
github-actions[bot] Mar 3, 2025
abfaa0e
safely dereferencing the vector branches for the compiler
tomeichlersmith Mar 3, 2025
ad07e7a
check length of vector before blinding indexing
tomeichlersmith Mar 3, 2025
2a7ea1d
Apply clang-format
github-actions[bot] Mar 3, 2025
b60ffa2
use back and front as suggested by Tamas
tomeichlersmith Mar 4, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
dont need to inherit from std::iterator anymore in C++20
tomeichlersmith committed Feb 28, 2025
commit 3fbad7308d6c86c8973c87fc5137ae04500ddc7b
5 changes: 2 additions & 3 deletions Recon/include/Recon/Event/HgcrocDigiCollection.h
Original file line number Diff line number Diff line change
@@ -437,8 +437,7 @@ class HgcrocDigiCollection {
* in the collection and only getting the digi when the iterator is
* asked to de-reference.
*/
class iterator
: public std::iterator<std::input_iterator_tag, HgcrocDigi, long> {
class iterator {
public:
/// Connect the parent collection with an index to this iterator
explicit iterator(HgcrocDigiCollection& c, long index = 0)
@@ -527,7 +526,7 @@ class HgcrocDigiCollection {
/**
* The ROOT class definition.
*/
ClassDef(HgcrocDigiCollection, 4);
ClassDef(HgcrocDigiCollection, 5);
};
} // namespace ldmx