Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce WAB Processor #1652

Merged
merged 17 commits into from
Mar 24, 2025
Merged

Introduce WAB Processor #1652

merged 17 commits into from
Mar 24, 2025

Conversation

SanjitMasanam
Copy link
Contributor

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

This resolves issue #1499

@SanjitMasanam SanjitMasanam linked an issue Mar 12, 2025 that may be closed by this pull request
@SanjitMasanam SanjitMasanam self-assigned this Mar 12, 2025
Copy link
Member

@tvami tvami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Sanjit!
I have a few comments but nothing major, mostly to make the code more efficient. I didnt comment everywhere but please move to floats when you can

@SanjitMasanam SanjitMasanam force-pushed the iss1499-introduce-wabProcessor branch from 5659ed8 to 938c0ef Compare March 13, 2025 19:17
…ances to x*x; added pass names;cleaned up code in general
@SanjitMasanam SanjitMasanam force-pushed the iss1499-introduce-wabProcessor branch from 938c0ef to e418c51 Compare March 13, 2025 19:19
@SanjitMasanam SanjitMasanam force-pushed the iss1499-introduce-wabProcessor branch from 8016b57 to 1c83de9 Compare March 13, 2025 20:17
@SanjitMasanam SanjitMasanam force-pushed the iss1499-introduce-wabProcessor branch from 1c83de9 to 90c9ff1 Compare March 13, 2025 20:18
@tvami tvami marked this pull request as draft March 13, 2025 20:44
@tvami tvami marked this pull request as ready for review March 13, 2025 20:44
@tvami tvami marked this pull request as draft March 14, 2025 05:15
@tvami tvami marked this pull request as ready for review March 14, 2025 05:15
Copy link
Member

@tvami tvami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No further comments, thanks!

@SanjitMasanam SanjitMasanam merged commit a8b73fd into trunk Mar 24, 2025
7 of 13 checks passed
@SanjitMasanam SanjitMasanam deleted the iss1499-introduce-wabProcessor branch March 24, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce WABProcessor
3 participants