Add Hcal digi from correct bar end, when zero suppression is turned off #1658
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the issues that this addresses?
I ran a simulation of the HCal prototype with zero suppression turned off, and expected the same amount of HCal digis on the positive end (0) of bars as on the negative end (1) (all bars have double-ended readout in the prototype). But the positive end had significantly more digis save to file:
UnbalancedEnds.pdf
By mistake, digis from activity on the negative end were not added properly. Digis that are pure noise are not effected by this, and this code block only runs when zero suppression is turned off. Simple one-line fix.
Check List
Now the ends are perfectly balanced:
BalancedEnds.pdf