Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hcal digi from correct bar end, when zero suppression is turned off #1658

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

Skelpdar
Copy link
Contributor

What are the issues that this addresses?

I ran a simulation of the HCal prototype with zero suppression turned off, and expected the same amount of HCal digis on the positive end (0) of bars as on the negative end (1) (all bars have double-ended readout in the prototype). But the positive end had significantly more digis save to file:

UnbalancedEnds.pdf

By mistake, digis from activity on the negative end were not added properly. Digis that are pure noise are not effected by this, and this code block only runs when zero suppression is turned off. Simple one-line fix.

Check List

  • I successfully compiled ldmx-sw with my developments.
  • I read, understood and follow the coding rules.
  • I ran my developments and the following shows that they are successful.

Now the ends are perfectly balanced:
BalancedEnds.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant