-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sidecar-extensibility): detect upgradeable contracts and pull ABIs from IPFS #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c05e33b
to
d91781e
Compare
seanmcgary
requested changes
Feb 13, 2025
Hi seri - great PR! Can we have a description please? |
@serichoi65 I'll let you fill in the PR body with implementation specifics. @non-fungible-nelson I added a link to the related github issue this addresses |
8c7f61d
to
dd4f27c
Compare
seanmcgary
requested changes
Feb 21, 2025
9e681ad
to
9fbc15f
Compare
87d25cb
to
eec3e53
Compare
seanmcgary
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to side-load contracts to Sidecar, we want to add the following features:
Non-feature updates:
AbiFetcher
as a new input toContractManager
pipelineIntegration_test
andrestakedStrategies_test
, should use a non-paid quiknode url addressNewClient
parameter withhttp.Client
to accept mocked clientFixes #223
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added tests to prove my fix is effective for all new modules by running
Checklist: