Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle edgecase where indexer hangs when a block has 0 transactions #247

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

seanmcgary
Copy link
Member

@seanmcgary seanmcgary commented Feb 13, 2025

Description

Bug fix for a situation observed on holesky where the indexer would hang when trying to batch fetch 0 transactions. This was only found when using a direct node rather than a service like quiknode since we typically dont use the native batch call structure with quiknode.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit test suite and manually running the sidecar to sync against the block that had 0 transactions on holesky.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@seanmcgary seanmcgary marked this pull request as ready for review February 14, 2025 04:49
@seanmcgary seanmcgary requested a review from a team as a code owner February 14, 2025 04:49
@seanmcgary seanmcgary requested a review from 0xrajath February 14, 2025 04:49
@seanmcgary seanmcgary merged commit c649e60 into master Feb 14, 2025
14 checks passed
@seanmcgary seanmcgary deleted the sm-frozenFix branch February 14, 2025 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant