Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved metrics collection and rpc logging #252

Merged
merged 3 commits into from
Feb 19, 2025
Merged

Conversation

seanmcgary
Copy link
Member

Description

  • Improved logging between grpc and http requests to better normalize logged fields
  • Emit metrics for rpc request handling in a uniform way so that you dont have to rely on parsing logs to extract data
  • Emit metrics to track block processing duration and rewards calculation duration

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Updated all unit tests. Observed RPC logs when running the rpc server locally for correct formatting.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@seanmcgary seanmcgary requested a review from a team as a code owner February 19, 2025 04:26
@seanmcgary seanmcgary requested a review from 0xrajath February 19, 2025 04:26
@seanmcgary seanmcgary merged commit 9cc370e into master Feb 19, 2025
13 checks passed
@seanmcgary seanmcgary deleted the sm-metrics branch February 19, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant