Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return correct columns for claimable rewards result #255

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

seanmcgary
Copy link
Member

Description

GetClaimableRewardsForEarner was scanning the wrong columns into the result struct resulting in a 0 value getting returned. This fixes GetClaimableRewardsForEarner to select the expected columns (token and amount) for the returned struct type.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tests and manual testing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@seanmcgary seanmcgary requested a review from a team as a code owner February 20, 2025 03:15
@seanmcgary seanmcgary requested a review from 0xrajath February 20, 2025 03:15
@seanmcgary seanmcgary merged commit 7eb6ed2 into master Feb 20, 2025
13 checks passed
@seanmcgary seanmcgary deleted the sm-summarizedFix branch February 20, 2025 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant