Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update query to use sql.Named rather than raw template #258

Merged
merged 1 commit into from
Feb 21, 2025
Merged

fix: update query to use sql.Named rather than raw template #258

merged 1 commit into from
Feb 21, 2025

Conversation

seanmcgary
Copy link
Member

Description

Use properly escaped query param for blockHeight rather than template string.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@seanmcgary seanmcgary requested a review from a team as a code owner February 20, 2025 22:05
@seanmcgary seanmcgary requested a review from 0xrajath February 20, 2025 22:05
@seanmcgary seanmcgary merged commit 8e092f4 into master Feb 21, 2025
14 checks passed
@seanmcgary seanmcgary deleted the sm-querySyntaxFix branch February 21, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xrajath 0xrajath Awaiting requested review from 0xrajath 0xrajath is a code owner automatically assigned from Layr-Labs/sidecar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@seanmcgary