Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore reward submissions with a duration of 0 #266

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

seanmcgary
Copy link
Member

Found during the rewards v2.1 audit, this prevents a potential division by 0 case since non-zero durations are not enforced by the RewardsCoordinator.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Added additional EigenState model tests.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Found during the rewards v2.1 audit, this prevents a potential division by 0 case
since non-zero durations are not enforced by the RewardsCoordinator.
@seanmcgary seanmcgary requested a review from a team as a code owner February 25, 2025 19:43
@seanmcgary seanmcgary merged commit bcffece into master Feb 25, 2025
14 checks passed
@seanmcgary seanmcgary deleted the sm-ignore0DurationRewards branch February 25, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants