WIP: allow hard deletes with synced subscribe #330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As someone who's thinking about adopting v3 this into an existing supabase project that doesn't use soft deletes at all, this would be pretty important for me, fwiw |
|
@amadeus I think the original issue was fixed so this PR is not needed and hard deletes are currently working fine? Is that right @warrenbhw? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in this issue, the docs don't make indication that synced subscribes require use of soft-deletes.
I just started hacking this in, but I'm going to pause and wait to complete in case someone chimes in with a reason why synced-subscribes fundametally require soft deletion.