Fixes sort issue #128
Open
Fixes sort issue #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tejas-hosamani thanks for the contribution, I did some blaming and find out the code for sorting is removed when I try to optimize the task parsing with async functions. I will build and test with your code, it will be merged in the next release if it goes well! |
|
Sounds good, thank you! |
Leonezz
requested changes
Jul 14, 2024
There was a problem hiding this comment.
Hi @tejas-hosamani please read the comments and check if there are changes needed.
| let taskList = adapter.getTaskList(); | ||
|
|
||
| const sortOptionFn = (0, eval)(this.userOptionModel.get("sort") || "") | ||
| if (sortOptionFn) taskList = taskList.sort(sortOptionFn) |
There was a problem hiding this comment.
sorting tasks here might not work cauze some fields of the task items might not get parsed yet.
you need to sort after all the meta infos are parsed.
|
|
||
| const sortOptionFn = (0, eval)(this.userOptionModel.get("sort") || "") | ||
| if (sortOptionFn) taskList = taskList.sort(sortOptionFn) | ||
|
|
||
| const taskListPromise = this.parseTasks(taskList) | ||
| taskListPromise.then(tasks => { | ||
| tasks = this.filterTasks(tasks); |
There was a problem hiding this comment.
add your sorting code after this would be good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue - #127