Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Firefox signing without explicit id #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

adamhwang
Copy link

@adamhwang adamhwang commented Feb 18, 2020

As of Firefox 48 the "id" property is now optional:
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_specific_settings

Extensions published after FF48 will automatically have its id generated. web-ext sign supports this through an optional "--id" flag:
https://extensionworkshop.com/documentation/develop/getting-started-with-web-ext#packaging-your-extension

This PR adds support to sign and publish Firefox addons without an explicit id in its manifest. Instead, the id can be specified with the env var WEXT_SHIPIT_FIREFOX_EXTENSION_ID. This further standardizes the way shipit publishes web extensions across browsers and provides the ability to use the same webext for all three supported extension stores.

Working example: https://travis-ci.com/adamhwang/ita-matrix-powertools/jobs/288630882

@kamalbennani
Copy link

@LinusU Any news regarding this? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants