Added web-ext --ignore-files option to args to ignore npm or yarn related files in firefox.js #6
Conversation
lib/firefox.js
Outdated
| @@ -20,6 +20,7 @@ module.exports = async function (source) { | |||
| 'sign', | |||
| '--source-dir', source, | |||
| '--api-key', process.env.WEXT_SHIPIT_FIREFOX_JWT_ISSUER, | |||
| '--ignore-files', '.api-key package.json package-lock.json yarn.lock .npmrc .yarnc', | |||
There was a problem hiding this comment.
I don't think that .api-key is a standardized file name 🤔 what's the rationale for including it here?
There was a problem hiding this comment.
Hi,
It's an example from Mozilla MDN reference documentation https://developer.mozilla.org/en-US/Add-ons/WebExtensions/web-ext_command_reference#Global_options
(Looks like some people do store their keys in a file of format "filename.api-key" )
However, I tried my changes from my gitlab and it didn't consider ignore-files option.. I raised an issue regarding that - it didn't seem to work when you call it within nodejs script. mozilla/web-ext#1333
In an earlier issue there mozilla/web-ext#843 , they did add ignore-files support for 'sign' - but that doesn't seem to pick for when you call it programmatically.. I guess "web-ext sign" from a CLI might work with ignore-files after that fix which they closed.
|
Hi @LinusU, updated the PR by correcting exclude pattern based on the comment in mozilla/web-ext#1333 (comment) |
Added web-ext --ignore-files option to args to ignore npm or yarn related files in firefox.js