modules/nebula: add nebula overlay network #1285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samasaur1
approved these changes
Jan 20, 2025
siriobalmelli
force-pushed
the
sb/nebula
branch
from
e12d16a to
7c2c315
Compare
Signed-off-by: Sirio Balmelli <[email protected]>
siriobalmelli
force-pushed
the
sb/nebula
branch
from
7c2c315 to
4809ed4
Compare
Enzime
requested changes
Feb 10, 2025
Comment on lines
+144
to
+148
| tun.device = mkOption { | ||
| type = types.nullOr types.str; | ||
| default = null; | ||
| description = "Name of the tun device. Defaults to nebula.\${networkName}."; | ||
| }; |
There was a problem hiding this comment.
Suggested change
| tun.device = mkOption { | |
| type = types.nullOr types.str; | |
| default = null; | |
| description = "Name of the tun device. Defaults to nebula.\${networkName}."; | |
| }; | |
| tun.device = mkOption { | |
| type = types.str; | |
| default = "nebula.\${networkName}"; | |
| description = "Name of the TUN device."; | |
| }; |
You'll probably also need to set defaultText
Comment on lines
+249
to
+251
| script = '' | ||
| exec ${cfg.package}/bin/nebula -config ${configFile} | ||
| ''; |
There was a problem hiding this comment.
Suggested change
| script = '' | |
| exec ${cfg.package}/bin/nebula -config ${configFile} | |
| ''; | |
| command = "${cfg.package}/bin/nebula -config ${configFile}"; |
Enzime
requested changes
Feb 10, 2025
| type = types.attrsOf ( | ||
| types.submodule { | ||
| options = { | ||
| enable = mkOption { |
There was a problem hiding this comment.
Suggested change
| enable = mkOption { | |
| enable = mkEnableOption { |
Can you replace all the booleans that default to false and just enable logic with mkEnableOption?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added on a similar pattern as netbird; this is in production on our systems locally.