chore: Feedback

LooksRare · Jul 17, 2023 · e7e027c · e7e027c
1 parent 415475c
commit e7e027c
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 2 deletions.
diff --git a/doc/interfaces/types.ChainInfo.md b/doc/interfaces/types.ChainInfo.md
@@ -57,3 +57,9 @@ ___
 ### rpcUrl
 
 • **rpcUrl**: `string`
+
+___
+
+### wsUrl
+
+• **wsUrl**: `string`
diff --git a/doc/modules/types.md b/doc/modules/types.md
@@ -52,6 +52,10 @@ ___
 
 Ƭ **Signer**: `ethers.Signer`
 
+**`See`**
+
+[Ethers Signer](https://docs.ethers.org/v6/api/providers/#Signer)
+
 ___
 
 ### SolidityType

diff --git a/src/__tests__/looksrare/createTaker.test.ts b/src/__tests__/looksrare/createTaker.test.ts
@@ -62,7 +62,7 @@ describe("Create takers", () => {
       );
 
       expect(taker.recipient).to.be.equal(signers.user2.address);
-      expect(Number(BigInt(itemId))).to.be.equal(1);
+      expect(BigInt(itemId)).to.be.equal(1n);
     });
 
     it("throw when quote type is wrong", async () => {
@@ -95,7 +95,7 @@ describe("Create takers", () => {
         taker.additionalParameters
       );
       expect(taker.recipient).to.be.equal(signers.user2.address);
-      expect(Number(BigInt(itemId))).to.be.equal(1);
+      expect(BigInt(itemId)).to.be.equal(1n);
     });
 
     it("throw when quote type is wrong", async () => {

diff --git a/src/types.ts b/src/types.ts
@@ -83,6 +83,9 @@ export interface BatchTransferItem {
   amounts: BigNumberish[];
 }
 
+/**
+ * @see {@link https://docs.ethers.org/v6/api/providers/#Signer Ethers Signer}
+ */
 export type Signer = ethers.Signer;
 
 /** Return type for any on chain call */