Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate to ethers v6 #164

Merged
merged 12 commits into from
Aug 3, 2023
Merged

feat: Migrate to ethers v6 #164

merged 12 commits into from
Aug 3, 2023

Conversation

perryrare
Copy link
Contributor

@perryrare perryrare commented Jul 12, 2023

Deps changes

  • Removed 0xsequence/multicall, as JsonRpcProvider from ethers v6 provides the batch functionality
  • Updated deps - hardhat, typechain, @typechain/hardhat to support ethers v6
  • Removed ethereum-waffle and @nomiclabs/hardhat-waffle, as they are actually not used, and there isn't yet new versions of them supporting ethers v5
  • Upgraded to ethers ^v6.6.2

Breaking changes

  • LooksRare class now requires JsonRpcProvider (from ethers v6), instead of base provider as before.

...

  • Updates tests. And they are passing ✅
  • FYI, major version is not bumped in this PR. To keep supporting ethers v5, we will have to manage the updates in 2 different branches. (e.g. master and ethers-v5)

@perryrare perryrare self-assigned this Jul 12, 2023
src/utils/calls/exchange.ts Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
hardhat.config.ts Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
src/__tests__/looksrare/createTaker.test.ts Outdated Show resolved Hide resolved
src/__tests__/looksrare/createTaker.test.ts Outdated Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
doc/modules/types.md Outdated Show resolved Hide resolved
doc/interfaces/types.Referrer.md Show resolved Hide resolved
RareBodhi
RareBodhi previously approved these changes Jul 19, 2023
src/types.ts Outdated Show resolved Hide resolved
src/LooksRare.ts Outdated Show resolved Hide resolved
@0xShisui 0xShisui merged commit 4b6d4bf into master Aug 3, 2023
4 checks passed
@0xShisui 0xShisui deleted the feature/ethers-v6-migration branch August 3, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants