-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate to ethers v6 #164
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/ethers-v6-migration
perryrare
commented
Jul 12, 2023
RareBodhi
reviewed
Jul 17, 2023
RareBodhi
previously approved these changes
Jul 19, 2023
0xShisui
reviewed
Jul 20, 2023
0xShisui
reviewed
Jul 20, 2023
0xShisui
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deps changes
0xsequence/multicall
, asJsonRpcProvider
fromethers v6
provides the batch functionalityhardhat
,typechain
,@typechain/hardhat
to support ethers v6ethereum-waffle
and@nomiclabs/hardhat-waffle
, as they are actually not used, and there isn't yet new versions of them supporting ethers v5ethers ^v6.6.2
Breaking changes
LooksRare
class now requiresJsonRpcProvider
(from ethers v6), instead of base provider as before....
master
andethers-v5
)