Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvements to interface #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

improvements to interface #11

wants to merge 1 commit into from

Conversation

ndchelsea
Copy link

  • allow Reason to be passed in parameters (resolves Ability to set "Reason" in failure cases #6)
  • allow callback to be passed in parameters, allowing one to easily use promises rather than needing to pass a custom context object to ensure resolve/reject is called

@ndchelsea
improvements to interface
dd8a943 
- allow Reason to be passed in parameters (resolves LukeMizuhashi#6)
- allow callback to be passed in parameters, allowing one to easily use
  promises rather than needing to pass a custom context object
  to ensure resolve/reject is called
@ndchelsea
Copy link
Author

I will try poking our account manager when I see him to see what sort of process there is around updating the official version per the readme, but wanted to put this up for review anyway since the hardcoded status reason is really obnoxious and the only solution I know of to make this work with promises is really hacky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to set "Reason" in failure cases
1 participant
@ndchelsea