Feature/formatting ci and linting #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feature/formatting-ci-and-linting
feature/formatting-ci-and-linting
feature/formatting-ci-and-linting
feature/formatting-ci-and-linting
feature/formatting-ci-and-linting
feature/formatting-ci-and-linting
feature/formatting-ci-and-linting
feature/formatting-ci-and-linting
feature/formatting-ci-and-linting
sam-mfb
reviewed
Mar 12, 2025
sam-mfb
reviewed
Mar 12, 2025
.swiftformat
Outdated
| --redundanttype explicit | ||
| --swiftversion 5.10 | ||
| --maxwidth 120 | ||
| --header "{file}\nSwiftyBeaver\n\nCopyright (c) 2015 Sebastian Kreutzberger\nAll rights reserved.\n\nCopyright 2025 MFB Technologies, Inc.\n\nThis source code is licensed under the MIT License (MIT) found in the\nLICENSE file in the root directory of this source tree." |
There was a problem hiding this comment.
You could just eliminate this header. I think for OSS projects a header in every file is overkill.
There was a problem hiding this comment.
Made this change as I understood it.
sam-mfb
previously approved these changes
Mar 12, 2025
There was a problem hiding this comment.
Copyright notices approved with suggestions. Note that not only do we not need to add our own copyright headers to files but the MIT license does not require us to maintain the original copyright headers. So long as we distribute the LICENSE.md file we have satisfied our obligations.
feature/formatting-ci-and-linting
feature/formatting-ci-and-linting
r-jarvis
requested changes
Mar 12, 2025
feature/formatting-ci-and-linting
r-jarvis
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.