Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CDF5 and int32 in files_for_e3sm #897

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Mar 26, 2025

The RRSwISC6to18E3r5 mesh had mesh, initial condition and mask files that were in NetCDF4 format, not CDF5. This PR aims to fix that.

We also have seen int64 fields in masks. This should be fixed in MPAS-Dev/MPAS-Tools#603, so this PR should introduce a new MPAS-Tools version that brings in that change as well.

For the MOC mask file in inputdata, this merge also adopts the naming convention from E3SM-Project/E3SM#7165, e.g.:

RRSwISC6to18E3r5_mocBasinsAndTransects20210623mg.20250205.nc

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

Sorry, something went wrong.

@xylar xylar self-assigned this Mar 26, 2025
@xylar xylar added bug Something isn't working ocean labels Mar 26, 2025
@xylar
Copy link
Collaborator Author

xylar commented Mar 27, 2025

Testing

I have tested this and MPAS-Dev/MPAS-Tools#603 together in:

/lcrc/group/e3sm/ac.xylar/compass_1.7/chrysalis/test_20250327/rrswisc6to18e3r5-files-for-e3sm-fix-cdf5-and-int32/ocean/global_ocean/files_for_e3sm

While not all steps have completed, I am not seeing any int64 and all output files except masks used for diagnostics are in cdf5 format as requested. (The diagnostics masks in netcdf4 format shouldn't cause any trouble.)

@xylar xylar marked this pull request as ready for review March 28, 2025 01:58
@xylar xylar marked this pull request as draft March 28, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant